Cppcheck suppressions set 56 #38744
Draft
Cppcheck suppressions set 56 #38744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Py_RETURN_NONE renamed to Py_NONE and return removed (now to be done manually) as not used anywhere else and was confusing cppcheck with missing return. Had to make lambda function wrapper if wanted to return const pointer in AlgorithmProperty.cpp Co-authored-by: Mohamed Almaki <[email protected]>
RichardWaiteSTFC
force-pushed
the
cppcheck_set56
branch
from
0f31aaf to
4cdedb9
Compare
|
Cancelling other tests as it seems there are genuine failures |
sf1919
added
the
Maintenance
| AlgorithmProperty *createPropertyWithValidator(const std::string &name, IValidator *validator) { | ||
| return createPropertyWithValidatorAndDirection(name, validator, Mantid::Kernel::Direction::Input); | ||
| } | ||
| const std::function<const AlgorithmProperty *(const std::string &, const IValidator *)> createPropertyWithValidator = |
There was a problem hiding this comment.
@MohamedAlmaki this is causing build failures any idea why?
There was a problem hiding this comment.
It appears that Boost::Python is having a problem reading the signature of the function pointer. I will attempt to resolve the error on my Linux machine, and if that is not possible, I may revert the change.
MohamedAlmaki
force-pushed
the
cppcheck_set56
branch
from
4cdedb9 to
53c7a22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
There is no associated issue. Part of cpp hackathon
Report to: @cailafinn
To test:
CI passes
This does not require release notes because will not affect the user
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.